Re: [PATCH 16/21] Introduce optional "keywords" on tag objects
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 10, 2007, 00:05 UTC
- Message-ID
- <7vfy50d67q.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <81b0412b0706091452q2957540dy95fbf13ebd89ca1f@mail.gmail.com>
"Alex Riesen" <raa.lkml@gmail.com> writes:
Show 18 quoted lines
> On 6/9/07, Johan Herland <johan@herland.net> wrote:
>> This patch introduces a new optional header line to the tag object, called
>> "keywords". The "keywords" line may contain a comma-separated list of
>> custom keywords associated with the tag object.
>
> What is the character set for the keywords?
>
>> + for (i = 0; i < keywords_len; ++i) {
>> + unsigned char c = keywords_line[i];
>> + if (c == ',' && keywords_line[i + 1] == ',')
>> + /* consecutive commas */
>> + return error("Tag object (@ char "
>> + PD_FMT "): Found empty keyword",
>> + keywords_line + i - data);
>> + if (c > ' ' && c != 0x7f)
>> + continue;
>
> And what is so special about 0x7f?It is DEL, but as the code uses uchar, it probably also error on 0x80 or higher, if the intent is "printable ASCII".