Re: [PATCH] Silence error messages unless 'thorough_verify' is set

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 10, 2007, 10:08 UTC
Message-ID: <Pine.LNX.4.64.0706101103160.4059@racer.site>
In-Reply-To: <7vwsyc8bt3.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sun, 10 Jun 2007, Junio C Hamano wrote:

Show 7 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > ...  Guess how surprised 
> > _I_ was, when I hit the error message which made me go mad.
> 
> To be fair, that ugly "char%d" was taken from mktag and not
> Johan's invention.

Yes, I should have said that. I tried to hint to this by "you could just as well clean the code up", meaning the existing code.

Now, _that_ would be a patch I'd be really thankful for.

As for the general direction of implementing notes as tags: If you want to make them fetchable, you have to deal with conflicts. If you want to be able to amend notes, _especially_ when they should be fetchable, you want a history on them.

Which makes me think that tags are not the right object type for notes.

But I guess I'll just wait if somebody actually comments on my RFC for lightweight commit annotations (that's what I put into that discussion). BTW I just realized that I marked it [PATCH], while it should have been [RFC]. Sorry.

Ciao, Dscho