Re: [PATCH 10/21] Free mktag's buffer before dying

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jun 9, 2007, 21:37 UTC
Message-ID: <81b0412b0706091437j50070e9aw7c258f136f4d5cde@mail.gmail.com>
In-Reply-To: <200706090216.41856.johan@herland.net>

On 6/9/07, Johan Herland <johan@herland.net> wrote:

> +       if (parse_and_verify_tag_buffer(0, buffer, size, 1)) {
> +               free(buffer);
> +               die("invalid tag data file");

This, and the similar one below are useless. You're destroying the process, what do you free that buffer for? Either handle the error case or do not needlessly complicate your change, which really also absolutely unneeded.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.