Re: [PATCH 1/4] Make tag names (i.e. the tag object's "tag" line) optional
- From
Johan Herland <johan@herland.net>
- Date
- Jun 10, 2007, 23:01 UTC
- Message-ID
- <200706110101.08664.johan@herland.net>
- In-Reply-To
- <7vps435sy0.fsf@assigned-by-dhcp.cox.net>
On Monday 11 June 2007, Junio C Hamano wrote:
Show 8 quoted lines
> Johan Herland <johan@herland.net> writes:
>
> > The tag line is now optional. If not given in the tag object data, it
> > defaults to the empty string ("") in the parsed tag object.
>
> Sorry, I may have missed the discussion. I recall that we
> talked about tagger line which may not exist for historical
> reasons, but have we heard any reasoning behind this?In the discussion that followed the first proof-of-concept of 'notes', I argued that the "tag" header is _really_ only needed for signed tag objects (although we want it for annotated tags as well), and that it doesn't make sense to specify a tag name for unnamed 'note' objects.
If the "tag" line remains mandatory, I'll have to construct an artificial name for unnamed 'notes'...
...Johan
-- Johan Herland, <johan@herland.net> www.herland.net