From: Johannes Schindelin Date: Sun, 10 Jun 2007 08:41:06 GMT Subject: Re: [PATCH 12/21] Use prefixcmp() instead of memcmp() for cleaner code with less magic numbers Message-ID: In-Reply-To: <200706090217.49818.johan@herland.net> Hi, On Sat, 9 Jun 2007, Johan Herland wrote: > > - if (memcmp(data, "object ", 7)) > + if (prefixcmp(data, "object ")) FWIW I think that _these_ changes are actually somewhat worth it. And they should have come _instead_ of moving the order of the memcmp() around (you know which patch that was). Ciao, Dscho