Re: [PATCH 13/23] fsmonitor-fs-listen-win32: implement FSMonitor backend on Windows

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 27, 2021, 17:41 UTC
Message-ID: <CAPig+cR8RUATo0cVZE5fQYOJjs+5v9-JfWdrz+A93Q5_Qr-ZpQ@mail.gmail.com>
In-Reply-To: <4b0066f5-5962-e57e-5987-5358f3d394f7@gmail.com>

On Tue, Apr 27, 2021 at 1:22 PM Derrick Stolee <stolee@gmail.com> wrote:

Show 9 quoted lines

> On 4/1/2021 11:40 AM, Jeff Hostetler via GitGitGadget wrote:
> > +     // TODO If an external <gitdir> is deleted, the above returns an error.
> > +     // TODO I'm not sure that there's anything that we can do here other
> > +     // TODO than failing -- the <worktree>/.git link file would be broken
> > +     // TODO anyway.  We might try to check for that and return a better
> > +     // TODO error message.
>
> These are not fit C-style comments. This situation can be handled
> by a later patch series, if valuable enough.

In this project, a comment like this would normally be prefixed by NEEDSWORK rather than TODO, and only the first line would carry the prefix line, not all of them.

    /* NEEDSWORK: the foinkster blorps the wooz */