Re: [PATCH v3 19/34] fsmonitor-fs-listen-win32: implement FSMonitor backend on Windows

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Jul 19, 2021, 22:35 UTC
Message-ID: <d2936252-50d7-7b3f-4707-7c07b17a09f3@jeffhostetler.com>
In-Reply-To: <20210717124535.GB16801@dcvr>

On 7/17/21 8:45 AM, Eric Wong wrote:

Show 14 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>> On Fri, Jul 16 2021, Johannes Schindelin wrote:
>>> Hi Ævar,
>>>
>>> On Tue, 13 Jul 2021, Ævar Arnfjörð Bjarmason wrote:
>>>
>>>>
>>>> On Tue, Jul 13 2021, Jeff Hostetler wrote:
>>>>
>>>>> On 7/1/21 7:02 PM, Ævar Arnfjörð Bjarmason wrote:
>>>>>> On Thu, Jul 01 2021, Jeff Hostetler via GitGitGadget wrote:
>>>>>>
>>>>>>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>>>>>>

...

Eric, welcome to the conversation and thanks for sharing your concerns.

For my upcoming V4 I've shortened the filenames of the various backends, renamed the -macos one to -darwin, and shortened the names of the fsm-listener API, and the names of those static functions associated with starting the daemon in the background.

I think this covers all of the issues raised across several patches in the series.

Jeff