Re: [PATCH v2 00/28] Builtin FSMonitor Feature

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Jun 22, 2021, 15:45 UTC
Message-ID: <6d302977-5360-b257-c9c0-9744311c6fae@jeffhostetler.com>
In-Reply-To: <xmqqmtsh9bhl.fsf@gitster.g>

On 5/26/21 10:06 PM, Junio C Hamano wrote:

Show 8 quoted lines

> These new global symbols are introduced by the series, but never
> used outside the file they are added to:
> 
> fsmonitor-ipc.o        - fsmonitor_ipc__get_path
> fsmonitor-ipc.o        - fsmonitor_ipc__get_state
> fsmonitor-ipc.o        - fsmonitor_ipc__send_command
> 
> Perhaps make them file-scope static?

I intended these to be part of the API for talking to a builtin FSMonitor. They are called from builtin/fsmonitor--daemon.c and t/helper/test-fsmonitor-client.c

Jeff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.