Re: [PATCH v3 12/34] fsmonitor-fs-listen-macos: stub in backend for MacOS

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Jul 27, 2021, 12:46 UTC
Message-ID: <38c22648-df46-2464-0c04-347dedbd04c6@jeffhostetler.com>
In-Reply-To: <xmqqr1fkfyh3.fsf@gitster.g>

On 7/26/21 7:26 PM, Junio C Hamano wrote:

Show 8 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
>> Hi Ævar,
>>
>> On Fri, 16 Jul 2021, Ævar Arnfjörð Bjarmason wrote:
>>
>>> On Fri, Jul 16 2021, Johannes Schindelin wrote:
>>>

...

I'm not sure that there is a "correct" answer here, but for the sake of harmony, in V4 I'll set this to "darwin" and update the name of the backend driver source file to match. So that we are consistently using 1 term throughout "Makefile" and "config.mak.uname".

	ifeq ($(uname_S),Darwin)
	...
		FSMONITOR_DAEMON_BACKEND = darwin
	endif

FWIW, I suspect that it is not worth the effort to directly set the backend name from $(uname_S). For example, on Windows we currently have two different uname values depending on which compiler is being used.

	ifeq ($(uname_S),Windows)
	...
		FSMONITOR_DAEMON_BACKEND = win32
	endif

	ifneq (,$(findstring MINGW,$(uname_S)))
	...
		FSMONITOR_DAEMON_BACKEND = win32
	endif

Also, since the backend layer is highly platform-specific, it may be a while (if ever) before we have universal coverage for all platforms. Until then, we can simply set $FSMONITOR_DAEMON_BACKEND to a literal value on a platform-by-platform basis as support is added.

Thanks, Jeff