From: Eric Sunshine Date: Tue, 27 Apr 2021 17:41:36 GMT Subject: Re: [PATCH 13/23] fsmonitor-fs-listen-win32: implement FSMonitor backend on Windows Message-ID: In-Reply-To: <4b0066f5-5962-e57e-5987-5358f3d394f7@gmail.com> On Tue, Apr 27, 2021 at 1:22 PM Derrick Stolee wrote: > On 4/1/2021 11:40 AM, Jeff Hostetler via GitGitGadget wrote: > > + // TODO If an external is deleted, the above returns an error. > > + // TODO I'm not sure that there's anything that we can do here other > > + // TODO than failing -- the /.git link file would be broken > > + // TODO anyway. We might try to check for that and return a better > > + // TODO error message. > > These are not fit C-style comments. This situation can be handled > by a later patch series, if valuable enough. In this project, a comment like this would normally be prefixed by NEEDSWORK rather than TODO, and only the first line would carry the prefix line, not all of them. /* NEEDSWORK: the foinkster blorps the wooz */