Re: [PATCH 06/23] fsmonitor--daemon: implement client command options

From: Derrick Stolee <stolee@gmail.com>
Date: Apr 26, 2021, 15:12 UTC
Message-ID: <098e4123-676e-2ea0-4c16-dbeaa1198b46@gmail.com>
In-Reply-To: <77170e521f67ce92587d833334f6951a9f375d4d.1617291666.git.gitgitgadget@gmail.com>

On 4/1/21 11:40 AM, Jeff Hostetler via GitGitGadget wrote:

Show 9 quoted lines

> From: Jeff Hostetler <jeffhost@microsoft.com>
> 
> Implement command options `--stop`, `--is-running`, `--query`,
> `--query-index`, and `--flush` to control and query the status of a
> `fsmonitor--daemon` server process (and implicitly start a server
> process if necessary).
> 
> Later commits will implement the actual server and monitor
> the file system.

As mentioned before, I think the "query", "query-index", and "flush" commands are better served in a test helper. Luckily, the implementation you give here seems rather straightforward and could fit into a test helper without a lot of duplicated boilerplate. That's a good sign for the API presented here.

As a bonus, you could delay the implementation of those test helpers until they are going to be used in a test.

Thanks, -Stolee