Re: [PATCH 07/23] fsmonitor-fs-listen-win32: stub in backend for Windows

From: Derrick Stolee <stolee@gmail.com>
Date: Apr 26, 2021, 15:23 UTC
Message-ID: <36e7dfeb-e833-ec11-f1b9-a596d560b35e@gmail.com>
In-Reply-To: <27f47dfbd9cf1103fcc5ffff9da6239c1a441987.1617291666.git.gitgitgadget@gmail.com>

On 4/1/21 11:40 AM, Jeff Hostetler via GitGitGadget wrote:

> +# If your platform supports an built-in fsmonitor backend, set
> +# FSMONITOR_DAEMON_BACKEND to the name of the corresponding
> +# `compat/fsmonitor/fsmonitor-fs-listen-<name>.c` that implements the
> +# `fsmonitor_fs_listen__*()` routines.

I found this to be a little confusing, specifically that you care about the "<name>" part of the filename, not the full file name. Here is an option:

# If your platform supports an built-in fsmonitor backend, set # FSMONITOR_DAEMON_BACKEND to "<name>", corresponding to the file # `compat/fsmonitor/fsmonitor-fs-listen-<name>.c` that implements the # `fsmonitor_fs_listen__*()` routines.

Everything else looks pretty standard. Good to create stubs this way so they can be consumed by a platform-agnostic caller and then implemented with that context.

Thanks, -Stolee