Re: [GSoC][PATCH v15 4/9] fsck: add a unified interface for reporting fsck messages

From: Karthik Nayak <karthik.188@gmail.com>
Date: Aug 7, 2024, 08:05 UTC
Message-ID: <CAOLa=ZQdmC+EQvxpqSjkXUo_PB2apkU2NteC49v6mvyxsByk8Q@mail.gmail.com>
In-Reply-To: <ZrEBvB9Urj8mG4i-@ArchLinux>

shejialuo <shejialuo@gmail.com> writes:

Show 8 quoted lines

> The static function "report" provided by "fsck.c" aims at checking error
> type and calling the callback "error_func" to report the message. Both
> refs and objects need to check the error type of the current fsck
> message. In order to extract this common behavior, create a new function
> "fsck_vreport". Instead of using "...", provide "va_list" to allow more
> flexibility.
>
> Instead of changing "report" prototype to be algin with the

Nit: s/be algin/align/

Rest of the patch looks great!

[snip]

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.