From: Karthik Nayak Date: Wed, 07 Aug 2024 08:05:39 GMT Subject: Re: [GSoC][PATCH v15 4/9] fsck: add a unified interface for reporting fsck messages Message-ID: In-Reply-To: shejialuo writes: > The static function "report" provided by "fsck.c" aims at checking error > type and calling the callback "error_func" to report the message. Both > refs and objects need to check the error type of the current fsck > message. In order to extract this common behavior, create a new function > "fsck_vreport". Instead of using "...", provide "va_list" to allow more > flexibility. > > Instead of changing "report" prototype to be algin with the Nit: s/be algin/align/ Rest of the patch looks great! [snip]