Re: [PATCH 1/2] refs.c: remove redundant translation markers

From: shejialuo <shejialuo@gmail.com>
Date: Oct 6, 2024, 10:01 UTC
Message-ID: <ZwJf7A9vnRWQgF41@ArchLinux>
In-Reply-To: <20241004191433.64416-1-tenglong.tl@alibaba-inc.com>

On Sat, Oct 05, 2024 at 03:14:33AM +0800, Teng Long wrote:

> From: Teng Long <dyroneteng@gmail.com>

[snip]

Show 25 quoted lines

> >> @@ -7,6 +9,9 @@
> >>  #define REFS_MIGRATE_USAGE \
> >>  	N_("git refs migrate --ref-format=<format> [--dry-run]")
> >>  
> >> +#define REFS_VERIFY_USAGE \
> >> +	N_("git refs verify [--strict] [--verbose]")
> 
> This define may not require translation, then maybe it should
> look like:
> 
> Signed-off-by: Teng Long <dyroneteng@gmail.com>
> ---
>  builtin/refs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/builtin/refs.c b/builtin/refs.c
> index 24978a7b..3a799aa6 100644
> --- a/builtin/refs.c
> +++ b/builtin/refs.c
> @@ -10,7 +10,7 @@
>  	N_("git refs migrate --ref-format=<format> [--dry-run]")
>  
>  #define REFS_VERIFY_USAGE \
> -	N_("git refs verify [--strict] [--verbose]")
> +	"git refs verify [--strict] [--verbose]"

I am OK with this change, actually I just followed the way what Patrick does for "git refs migrate" subcommand. So at first glance, I wonder why the "git refs migrate" subcommand usage should not be changed.

After searching the mailing list for information, I found that Junio has explained why in

	https://lore.kernel.org/git/xmqqbk5y3j8a.fsf@gitster.g/

Because `--ref-format` could be used as the placeholder, it will be much more helpful when translating in a different locale.

Thanks, Jialuo