Re: [GSoC][PATCH v15 0/9] ref consistency check infra setup
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Aug 7, 2024, 09:29 UTC
- Message-ID
- <CAOLa=ZTuJC8HhSZo88PANAC4sntKWPFTprjbF5bks0tMg414pg@mail.gmail.com>
- In-Reply-To
- <ZrEBKjzbyxtMdCCx@ArchLinux>
shejialuo <shejialuo@gmail.com> writes:
Show 20 quoted lines
> Hi All: > > This version handles the following problems: > > 1. Patrick advices that I should not use `va_copy` in the changed > `report` function. Actually this is a mistake, this version avoids > redundant `ap` copy. > 2. Patrick advices I should rebase [v14 05/11] into [v14 04/11]. I > follow this advice in this version. > 3. Patrick advices that we should put [v14 06/11] before we introduce > ref-related operations. This version reorders the commit sequence. It's > a minor change. > 4. Patrick suggests at current we should not add `git refs verify` > command into "git-fsck(1)". This is because we should disable this new > check by default for the users. Many users use "git-fsck(1)" in their daily > workflow. We should not be aggressive. However, if we provide this > mechanism in this series, we will again make more complexity. So this > version drop patch [v14 09/11]. Also because of dropping, change the > test file to use "git refs verify" command instead of "git fsck" > command.
This is the biggest change in this version and it makes sense. It can still be added later on, but for now users can use this via `git refs verify`.
> 5. Patrick suggests that we should use `ends_with` instead of > `strip_suffix`, fix. >
Apart from the minor nits, I think this version looks good. Thanks!