Re: [GSoC][PATCH v9 4/9] refs: set up ref consistency check infrastructure

From: Justin Tobler <jltobler@gmail.com>
Date: Jul 9, 2024, 22:11 UTC
Message-ID: <b7apetyejg5ycvvqkc5motpx45mbval5sixvlgwfrh4q5lzc5d@b32kkwo4qeer>
In-Reply-To: <Zo0umVPABD1wkxQG@ArchLinux>

On 24/07/09 08:35PM, shejialuo wrote:

Show 13 quoted lines

> The interfaces defined in the `ref_storage_be` are carefully structured
> in semantic. It's organized as the five parts:
> 
> 1. The name and the initialization interfaces.
> 2. The ref transaction interfaces.
> 3. The ref internal interfaces (pack, rename and copy).
> 4. The ref filesystem interfaces.
> 5. The reflog related interfaces.
> 
> To keep consistent with the git-fsck(1), add a new interface named
> "fsck_refs_fn" to the end of "ref_storage_be". This semantic cannot be
> grouped into any above five categories. Explicitly add blank line to
> make it different from others.

In this patch we are not only adding the `fsck` infrastructure to `ref_storage_be`, but also wiring what are essentially no-op functions to the various implementations. It might be good to mention this in the commit message so it is better understood that future patches will actually provide proper function implementations.

-Justin