Re: [GSoC][PATCH v3 0/7] ref consistency check infra setup

From: jialuo she <shejialuo@gmail.com>
Date: Jun 18, 2024, 15:56 UTC
Message-ID: <CAH-kW5e079dkg99C3rroj+vh6C2L6roqVFYWg_Ykno3WVpHOhg@mail.gmail.com>
In-Reply-To: <xmqq8qz22r6r.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 28 quoted lines

>
> shejialuo <shejialuo@gmail.com> writes:
>
> > This is the third version. Mainly focuses on the following problems:
> >
> > 1. Add "escape" check for symrefs and symbolic links.
> > 2. Resolve the reviews.
> > 3. Fix some errors in version 2.
> >
> > shejialuo (7):
> >   fsck: add refs check interfaces to interface with fsck error levels
> >   refs: set up ref consistency check infrastructure
> >   builtin/refs: add verify subcommand
> >   builtin/fsck: add `git-refs verify` child process
> >   files-backend: add unified interface for refs scanning
> >   fsck: add ref name check for files backend
> >   fsck: add ref content check for files backend
>
> What commit is this series based on?  It does not seem to apply
> cleanly on top of the same base as I queued an earlier iteration of
> this series (f931bfb2 (Merge branch 'ps/ref-storage-migration' into
> sj/ref-fsck, 2024-06-13)), or the current tip of 'master' that
> already merges that prerequisite topic.  The early 6 applies on top
> of 'master' fine, but the last one.  I wiggled the last one in (the
> patch to the fsck-msgids.txt documentation expects stale entries
> that were already removed in 2.45.2), but if you are basing your
> patches on an unusual commit, please describe it clearly here in the
> cover letter so that others can locate (or recreate as needed) it.

Well, I simply does "git checkout -b js-refs-fsck-v3" for the current branch "js-refs-fsck". And I use "git rebase" to change the code in this branch. So the base commit should be unchanged. However, maybe Patrick has changed the code and I forgot to update upstream.

And I have set up the base using the following commands:

  $ git remote add junio https://github.com/gister/git.git
  $ git fetch junio
  $ git branch js-refs-fsck junio/ps/ref-storage-migration

I am sorry for the confusion. Next version, I will merge the master code and send the patch. I am sorry to make you so inconvenient.