Re: [GSoC][PATCH v14 06/11] fsck: rename objects-related fsck error functions

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 5, 2024, 12:58 UTC
Message-ID: <ZrDMbnIgGNK8F99N@tanuki>
In-Reply-To: <ZqumVWxLZpBYkrGB@ArchLinux>

On Thu, Aug 01, 2024 at 11:14:29PM +0800, shejialuo wrote:

Show 5 quoted lines

> The names of objects-related fsck error functions are generic. It's OK
> when there is only object database check. However, we have introduced
> refs database check report function. To avoid ambiguity, rename
> object-related fsck error functions to explicitly indicate these
> functions are used to report objects-related messages.

Nit: I think it would be a bit easier to follow if you moved this step
a bit earlier, namely before you introduce the ref-related infra.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.