Re: [GSoC][PATCH v15 3/9] fsck: make "fsck_error" callback generic

From: Karthik Nayak <karthik.188@gmail.com>
Date: Aug 7, 2024, 08:03 UTC
Message-ID: <CAOLa=ZRV4A2CyugxghHEE6qoaZ1b8aubyDOTC9PuDo1DJLa30A@mail.gmail.com>
In-Reply-To: <ZrEBsym854FtguPI@ArchLinux>

shejialuo <shejialuo@gmail.com> writes:

Show 10 quoted lines

> The "fsck_error" callback is designed to report the objects-related
> error messages. It accepts two parameter "oid" and "object_type" which
> is not generic. In order to provide a unified callback which can report
> either objects or refs, remove the objects-related parameters and add
> the generic parameter "void *fsck_report".
>
> Create a new "fsck_object_report" structure which incorporates the
> removed parameters "oid" and "object_type". Then change the
> corresponding references to adapt to new "fsck_error" callback.
>

So since my last review, we've now changed the function to accept a 'void *' parameter, this makes sense, this way the refs error function and the objects error function can now only receive the data they care about.

[snip]