Re: [PATCH 6/6] sequencer: factor code out of revert builtin

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Jan 10, 2012, 15:21 UTC
Message-ID: <CALkWK0mYPS+FRihHOGfoK52nvKfNh9rGFdy=_0hri+uqocRzBA@mail.gmail.com>
In-Reply-To: <20120108203800.GM1942@burratino>

Jonathan Nieder wrote:

Show 10 quoted lines

> Ramkumar Ramachandra wrote:
>>   memset(&opts, 0, sizeof(opts));
>>   opts.command = REPLAY_CMD_FOO;
>>   opts.revisions = xmalloc(sizeof(*opts.revs));
>>   parse_args_populate_opts(argc, argv, &opts);
>>   init_revisions(opts.revs);
>>   sequencer_pick_revisions(&opts);
>
> Hm, I wonder if opts.command should be a string so each new caller
> does not have to add to the enum and switch statements...

The new caller would have to add enum and switch statements to define a new action anyway, so I think this should be an enum too.

-- Ram

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.