Re: [PATCH 4/8] revert: separate out parse errors logically

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 10, 2012, 19:03 UTC
Message-ID: <20120110190311.GD22184@burratino>
In-Reply-To: <1326212039-13806-5-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra wrote:

>                 For the first kind of error, it is insufficient to
> check if the buffer beings with a "pick" or "revert", otherwise the
> following insn sheet would be interpreted as having a malformed object
> name:

Show 5 quoted lines

> pickle a1fe57~2
>
> In reality, the issue is that "pickle" is an unrecognized instruction.
> So, check that the buffer starts with ("pick " or "pick\t") and
> ("revert " or "revert\t").

Sorry, the above description just leaves me more confused than before.

What _actual impact_ does this patch have? And why do we want it? And what could be the bad side effects? Everything else is just irrelevant.

Before reading the above description, I thought this was just a code cleanup. So either the description or my reading is completely confused.