Re: [PATCH 2/6] revert: decouple sequencer actions from builtin commands

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Jan 8, 2012, 19:53 UTC
Message-ID: <CALkWK0kHn+SDaeRHa8bUHWvOEVkr01sVDzvnw9E+-Nne2cii1Q@mail.gmail.com>
In-Reply-To: <20120108193454.GG1942@burratino>

Jonathan Nieder wrote:

Show 13 quoted lines

> Ramkumar Ramachandra wrote:
>
>>                                                  So, while a future
>> instruction sheet would look like:
>>
>>   pick next~4
>>   action3 b74fea
>>   revert rr/moo^2~34
>>
>> the actions "pick", "action3" and "revert" need not necessarily
>> correspond to the specific builtins.
>
> So what change does the patch actually make?  Is this a renaming?

Yes, it renames "action" to "command" where appropriate.

Show 12 quoted lines

> [...]
>> --- a/builtin/revert.c
>> +++ b/builtin/revert.c
> [...]
>> @@ -64,16 +64,21 @@ struct replay_opts {
>>
>>  #define GIT_REFLOG_ACTION "GIT_REFLOG_ACTION"
>>
>> -static const char *action_name(const struct replay_opts *opts)
>> +static const char *command_name(struct replay_opts *opts)
>
> Why is the const being dropped?  I'm lost, so not reading further.

Minor error.  The rest of the patch should be fine.

-- Ram