Hi,
The big changes in this round are:
1. Dropped "revert: don't let revert continue a cherry-pick" from the
last round after a quick discussion with Jonathan.
2. Separated out "revert: separate out parse errors logically" from
"revert: report fine-grained errors from insn parser". Definitely
looks clearer.
3. Improved "revert: report fine-grained errors from insn parser" by
eliminating repetition. 20 is a bit arbitrary, but it looks pretty
enough on my terminal.
4. Added "sha1_name: introduce getn_sha1() to take length" and
"revert: use getn_sha1() to simplify insn parsing". I'm happy with
them. Name is inspired from the strncmp() variant of strcmp().
5. Included minimal API documentation with "sequencer: factor code out
of revert builtin".
Thanks for reading. I think I'll work on fixing the memory leaks now.
Ramkumar Ramachandra (8):
revert: prepare to move replay_action to header
revert: decouple sequencer actions from builtin commands
revert: allow mixing "pick" and "revert" actions
revert: separate out parse errors logically
revert: report fine-grained errors from insn parser
sha1_name: introduce getn_sha1() to take length
revert: use getn_sha1() to simplify insn parsing
sequencer: factor code out of revert builtin
Documentation/technical/api-sequencer.txt | 22 +
builtin/revert.c | 958 +----------------------------
cache.h | 1 +
sequencer.c | 925 ++++++++++++++++++++++++++++-
sequencer.h | 48 ++
sha1_name.c | 23 +-
t/t3510-cherry-pick-sequence.sh | 46 +-
7 files changed, 1056 insertions(+), 967 deletions(-)
create mode 100644 Documentation/technical/api-sequencer.txt