Re: [PATCH v3 0/2] The move to sequencer.c
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jan 11, 2012, 18:40 UTC
- Message-ID
- <20120111184036.GC3005@burratino>
- In-Reply-To
- <1326305757-27525-1-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra wrote:
> Ramkumar Ramachandra (2): > revert: prepare to move replay_action to header > sequencer: factor code out of revert builtin
Ah. "git diff HEAD^:builtin/revert.c HEAD:sequencer.c" gives a sane diff, and the remaining stuff in builtin/revert.c feels pleasant.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Here's a patchlet for squashing into patch 2/2. --- builtin/revert.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/builtin/revert.c b/builtin/revert.c index 4116f2d3..e6840f23 100644 --- a/builtin/revert.c +++ b/builtin/revert.c @@ -30,8 +30,6 @@ static const char * const cherry_pick_usage[] = { NULL }; -#define GIT_REFLOG_ACTION "GIT_REFLOG_ACTION" - static const char *action_name(const struct replay_opts *opts) { return opts->action == REPLAY_REVERT ? "revert" : "cherry-pick";