Re: [PATCHv2 1/8] Makefile: apply dependencies consistently to sparse/asm targets
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jun 20, 2012, 19:30 UTC
- Message-ID
- <CAFzf2Xw3TdvZCFLvbqKY5F9b+0hTzTQEEfmqjL9u=uvyc7mZ5w@mail.gmail.com>
- In-Reply-To
- <20120620182855.GA26948@sigill.intra.peff.net>
Jeff King wrote:
Show 5 quoted lines
> Here's an updated series that drops these lines and I hope will address > the commit message issues you brought up: > > [01/11]: Makefile: sort LIB_H list > [02/11]: Makefile: fold MISC_H into LIB_H
Please no. Progress would be teaching the remaining compilers to autocompute header dependencies so there would be no need to maintain a master header list at all. I would understand if the headers had been falling out of date and this were a way of saying "we give up", but given that that is not happening, why would this change be a good thing?
My comments were only about explaining what I found hard to understand in the commit message. The patch was good. Please don't retaliate this way. :)
Hope that helps, Jonathan