Re: [PATCHv3 04/11] Makefile: apply dependencies consistently to sparse/asm targets

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 20, 2012, 21:12 UTC
Message-ID: <20120620211225.GD6142@burratino>
In-Reply-To: <20120620183133.GD30995@sigill.intra.peff.net>

Jeff King wrote:

Show 5 quoted lines

>                                                      These
> flags may sometimes require extra dependencies to be added
> (e.g., like GIT-VERSION-FILE; this is not the case for any
> of the updated lines in this patch, but it is establishing a
> style that will be used in later patches).

[...]

> This patch explicitly does not update the static header
> dependencies used when COMPUTED_HEADER_DEPENDENCIES is off.

I think you are asking the commit message to do more work than it needs to, and to answer questions that no one just trying to understand the patch would ask. :)

Wouldn't it be simpler to put the ground rules in a comment or a document somewhere under Documentation/ where they can be easily found?

Hope that helps, Jonathan