Re: [PATCHv3 06/11] Makefile: split GIT_USER_AGENT from GIT-CFLAGS
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jun 20, 2012, 22:21 UTC
- Message-ID
- <20120620222103.GJ6142@burratino>
- In-Reply-To
- <20120620221616.GC3302@sigill.intra.peff.net>
Jeff King wrote:
>> Jeff King wrote:
>>> + @if test x'$(GIT_USER_AGENT_SQ)' != x"`cat GIT-USER-AGENT 2>/dev/null`"; then \ >>> + echo >&2 " * new user-agent flag"; \
[...]
> I am tempted to get rid of the informative message altogether. > For CFLAGS, you might be confused why everything is being rebuilt, since > the dependency chain is not straightforward. For this, it's kind of > obvious.
Makes a lot of sense.