Re: [PATCH 02.5/11] Makefile: fold XDIFF_H and VCSSVN_H into LIB_H
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 9, 2012, 14:59 UTC
- Message-ID
- <7vfw91kmj6.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120707033918.GB3574@burratino>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 19 quoted lines
> Just like MISC_H (see previous commit), there is no reason to track > xdiff and vcs-svn headers separately from the rest of the headers. > The only purpose of these variables is to keep track of recompilation > dependencies. > > As a pleasant side effect, folding these into LIB_H lets us stop > tracking GIT_OBJS and VCSSVN_TEST_OBJS separately from the list of all > OBJECTS. > > Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> > --- > Jeff King wrote: >> On Wed, Jun 20, 2012 at 04:07:30PM -0500, Jonathan Nieder wrote: > >>> Should XDIFF_H and VCSSVN_H be folded into STATIC_HEADERS, too? >> >> I stopped short of that, but I'd be tempted to do so. > > Here goes.
Very tempting. Will try squeezing this in between 2/11 and 3/11 and see how the result looks.