Re: [PATCHv3 04/11] Makefile: apply dependencies consistently to sparse/asm targets

From: Jeff King <peff@peff.net>
Date: Jun 20, 2012, 22:15 UTC
Message-ID: <20120620221502.GB3302@sigill.intra.peff.net>
In-Reply-To: <20120620211225.GD6142@burratino>

On Wed, Jun 20, 2012 at 04:12:25PM -0500, Jonathan Nieder wrote:

Show 14 quoted lines

> Jeff King wrote:
> 
> >                                                      These
> > flags may sometimes require extra dependencies to be added
> > (e.g., like GIT-VERSION-FILE; this is not the case for any
> > of the updated lines in this patch, but it is establishing a
> > style that will be used in later patches).
> [...] 
> > This patch explicitly does not update the static header
> > dependencies used when COMPUTED_HEADER_DEPENDENCIES is off.
> 
> I think you are asking the commit message to do more work than it
> needs to, and to answer questions that no one just trying to
> understand the patch would ask. :)

Yeah, when writing out the full discussion I was awfully tempted to go with your simplified explanation. ;)

In fact, it's the later commits that really make use of this explanation when they add lines.

> Wouldn't it be simpler to put the ground rules in a comment or a
> document somewhere under Documentation/ where they can be easily
> found?

I think a comment in the Makefile might make sense (especially if it introduces the section as "and this is the place to put weird target-specific cppflags and dependencies"). Would you mind taking a stab at writing it? I feel like the explanation I wrote in the commit message ended up quite dense and possibly not very informative, and a fresh brain and fingers might turn out something a little more reasonable.

-Peff