Re: [PATCHv2 1/8] Makefile: apply dependencies consistently to sparse/asm targets
Jeff King <peff@peff.net> writes:
Show 29 quoted lines
> Here's an updated series that drops these lines and I hope will address
> the commit message issues you brought up:
>
> [01/11]: Makefile: sort LIB_H list
> [02/11]: Makefile: fold MISC_H into LIB_H
>
> New in this iteration to get rid of these largely pointless manual
> dependencies.
>
> [03/11]: Makefile: do not have git.o depend on common-cmds.h
>
> New in this iteration. I noticed while double-checking that this
> dependency is pointless.
>
> [04/11]: Makefile: apply dependencies consistently to sparse/asm targets
>
> Updated based on earlier patches, and with a new commit message
> explaining a little more of what's going on.
>
> [05/11]: Makefile: do not replace @@GIT_USER_AGENT@@ in scripts
> [06/11]: Makefile: split GIT_USER_AGENT from GIT-CFLAGS
> [07/11]: Makefile: split prefix flags from GIT-CFLAGS
> [08/11]: Makefile: do not replace @@GIT_VERSION@@ in shell scripts
> [09/11]: Makefile: update scripts when build-time parameters change
> [10/11]: Makefile: build instaweb similar to other scripts
> [11/11]: Makefile: move GIT-VERSION-FILE dependencies closer to use
>
> The rest are largely the same, but with a few minor textual updates to
> accomodate the earlier changes.
Looks good modulo a minor nit. Will queue.
Thanks.