Re: [PATCHv3 01/11] Makefile: sort LIB_H list
- From
Jeff King <peff@peff.net>
- Date
- Jun 20, 2012, 20:01 UTC
- Message-ID
- <20120620200151.GA388@sigill.intra.peff.net>
- In-Reply-To
- <7vwr31u532.fsf@alter.siamese.dyndns.org>
On Wed, Jun 20, 2012 at 01:00:01PM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> Jeff King <peff@peff.net> writes: > > > This was mostly sorted already, but put things like > > "cache-tree.h" after "cache.h", even though "-" comes before > > "." (at least in the C locale). This will make it easier to > > keep the list sorted later by piping it through "sort". > > I agree this would make it easier to blindly run "sort", but I think > the result hurts scannability. Is it a good change?
I don't personally see a difference, but if you do, I don't care that much about this patch. The main motive was that the next patch involved adding 10 new entries, and I didn't want to have to insert them manually into the correct sorting spots.
-Peff