Re: [PATCHv3 06/11] Makefile: split GIT_USER_AGENT from GIT-CFLAGS
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jun 20, 2012, 21:21 UTC
- Message-ID
- <20120620212135.GE6142@burratino>
- In-Reply-To
- <20120620183151.GF30995@sigill.intra.peff.net>
Jeff King wrote:
> + @if test x'$(GIT_USER_AGENT_SQ)' != x"`cat GIT-USER-AGENT 2>/dev/null`"; then \ > + echo >&2 " * new user-agent flag"; \
Micronit: the term "new user-agent string" would be clearer.
Re the lack of _HTTP: interesting. Is the plan to use this for other protocols, too?
Looks good. Jonathan