Re: [PATCH v3 5/8] common.h: move non-compat specific macros and functions

From: Calvin Wan <calvinwan@google.com>
Date: Jun 13, 2023, 22:42 UTC
Message-ID: <CAFySSZBf51JFAY5fYRsYvk2RkZ8rDmoQOHKrCte4ERkBeoiJWA@mail.gmail.com>
In-Reply-To: <xmqq8rco9zkl.fsf@gitster.g>

Show 6 quoted lines

> > Is there a particular problem here?
>
> Doesn't it defeat the notion that each header file is safe to
> include twice via "#ifndef FOO/#define FOO/#endif" safeguard and
> makes anybody who sees the recursive inclusion to think twice before
> they can convince themselves that it is OK for this particular pair?

In that case do you have any recommendations as to how I can make clear that this recursive inclusion isn't problematic or refactor away the recursive inclusion without having to change the header inclusions of every other Git file?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.