Re: [PATCH v2 7/7] common: move alloc macros to common.h

From: Jonathan Tan <jonathantanmy@google.com>
Date: May 26, 2023, 21:27 UTC
Message-ID: <20230526212759.2294075-1-jonathantanmy@google.com>
In-Reply-To: <20230523192949.1271671-7-calvinwan@google.com>

Calvin Wan <calvinwan@google.com> writes:

Show 7 quoted lines

> alloc_nr, ALLOC_GROW, and ALLOC_GROW_BY are commonly used macros for
> dynamic array allocation. Moving these macros to common.h focuses
> alloc.[ch] to allocation for Git objects and additionally allows us to
> remove inclusions to alloc.h from files that solely used the above
> macros.
> 
> Signed-off-by: Calvin Wan <calvinwan@google.com>

Ah, indeed, "alloc.h" was used for 2 different allocation-related
things. This change makes sense, of course.
 
Thanks for this patch set. Overall, it looks good (except for some minor
comments that I've given in other emails).

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.