Re: [PATCH v2 1/7] strbuf.h: move declarations for strbuf.c functions from git-compat-util.h

From: Jonathan Tan <jonathantanmy@google.com>
Date: May 26, 2023, 21:06 UTC
Message-ID: <20230526210633.2290844-1-jonathantanmy@google.com>
In-Reply-To: <20230523192949.1271671-1-calvinwan@google.com>

Calvin Wan <calvinwan@google.com> writes:

Show 5 quoted lines

> While functions like starts_with() probably should not belong in the
> boundaries of the strbuf library, this commit focuses on first splitting
> out headers from git-compat-util.h.
> 
> Signed-off-by: Calvin Wan <calvinwan@google.com>

I know we don't follow the 50-character rule for commit message headers all the time, but I don't think it's necessary to break it here for a relatively simple-to-explain change. Maybe "git-compat-util: move strbuf.c funcs to its header". Same for the other patches.

The patch itself looks good.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.