From: Calvin Wan <calvinwan@google.com>
Date: Tue, 13 Jun 2023 22:42:25 GMT
Subject: Re: [PATCH v3 5/8] common.h: move non-compat specific macros and functions
Message-ID: <CAFySSZBf51JFAY5fYRsYvk2RkZ8rDmoQOHKrCte4ERkBeoiJWA@mail.gmail.com>
In-Reply-To: <xmqq8rco9zkl.fsf@gitster.g>

> > Is there a particular problem here?
>
> Doesn't it defeat the notion that each header file is safe to
> include twice via "#ifndef FOO/#define FOO/#endif" safeguard and
> makes anybody who sees the recursive inclusion to think twice before
> they can convince themselves that it is OK for this particular pair?

In that case do you have any recommendations as to how I can make
clear that this recursive inclusion isn't problematic or refactor away
the recursive inclusion without having to change the header inclusions
of every other Git file?