Re: [PATCH v2 2/7] wrapper.h: move declarations for wrapper.c functions from git-compat-util.h

From: Jonathan Tan <jonathantanmy@google.com>
Date: May 26, 2023, 21:25 UTC
Message-ID: <20230526212525.2293692-1-jonathantanmy@google.com>
In-Reply-To: <20230523192949.1271671-2-calvinwan@google.com>

Calvin Wan <calvinwan@google.com> writes:

Show 5 quoted lines

> Since the functions in wrapper.c are widely used across the codebase,
> include it by default in git-compat-util.h. A future patch will remove
> now unnecessary inclusions of wrapper.h from other files.
> 
> Signed-off-by: Calvin Wan <calvinwan@google.com>

Thanks. So currently, if you wanted to xmmap, you don't have to include
wrapper.h, but if you wanted to read_in_full, you do. Making Git code
treat functions like those 2 in the same way makes sense to me.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.