Re: [PATCH v3 5/8] common.h: move non-compat specific macros and functions

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 12, 2023, 20:48 UTC
Message-ID: <xmqq8rco9zkl.fsf@gitster.g>
In-Reply-To: <CAFySSZBZVn=7gBB19_uNxeUwS9Y8Q6ZZiCT=AwfuBy4+d34piw@mail.gmail.com>

Calvin Wan <calvinwan@google.com> writes:

> Is there a particular problem here?

Doesn't it defeat the notion that each header file is safe to include twice via "#ifndef FOO/#define FOO/#endif" safeguard and makes anybody who sees the recursive inclusion to think twice before they can convince themselves that it is OK for this particular pair?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.