Re: [PATCH v2 3/7] sane-ctype.h: move sane-ctype macros from git-compat-util.h

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 1, 2023, 04:12 UTC
Message-ID: <xmqqjzwnes6w.fsf@gitster.g>
In-Reply-To: <20230526211911.2291886-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> Any specific reason for the "sane-" prefix? I think it would make more
> sense if it was just named ctype.h: see below.

I think it is a good idea to keep the sane prefix for two reasons that were described in 4546738b (Unlocalized isspace and friends, 2005-10-13):

    Do our own ctype.h, just to get the sane semantics: we want
    locale-independence, _and_ we want the right signed behaviour. Plus we
    only use a very small subset of ctype.h anyway (isspace, isalpha,
    isdigit and isalnum).

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.