Re: [PATCH v3 5/8] common.h: move non-compat specific macros and functions

> git-compat-util.h has grown to a large and difficult to read file partly
> because its set of functionality is overloaded. Besides being a
> compatibility file that ensures Git's operation across different
> operating systems, it has also become a dumping ground for commonly used
> macros and static inline functions.
> 
> This commit separates out macros and static inline functions that are
> compatible across operating systems into common.h. common.h is
> reincluded back into git-compat-util.h so that other files do not also
> have to include it. The eventual goal is for common.h to be separated
> out into more reasonable boundaries, but for now this should be a good
> first step towards that goal.
> 
> Signed-off-by: Calvin Wan <calvinwan@google.com>
> ---
>  common.h          | 410 ++++++++++++++++++++++++++++++++++++++++++++++
>  git-compat-util.h | 402 +--------------------------------------------
>  2 files changed, 412 insertions(+), 400 deletions(-)
>  create mode 100644 common.h
> 
> diff --git a/common.h b/common.h
> new file mode 100644
> index 0000000000..0f164c1071
> --- /dev/null
> +++ b/common.h
> @@ -0,0 +1,410 @@
> +#ifndef COMMON_H
> +#define COMMON_H
> +
> +#include "git-compat-util.h"