git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Move sequencer to builtin

From
Duy Nguyen <pclouds@gmail.com>
Date
Jun 8, 2013, 02:35 UTC
Message-ID
<CACsJy8AMMCWSFC6EUHAgZdDA7E1kSPE3ZO6qGvS+WGji-di=Rw@mail.gmail.com>
In-Reply-To
<1370643409-3431-3-git-send-email-felipe.contreras@gmail.com>

On Sat, Jun 8, 2013 at 5:16 AM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

> This code is only useful for cherry-pick and revert built-ins, nothing
> else, so let's make it a builtin object, but make sure 'git-sequencer'
> is not generated.

As you can see, the convention is builtin/foo.c corresponds to git-foo (and maybe more). Why make an exception for sequencer? What do we gain from this? A lot of code in libgit.a is only used by builtin commands, e.g. fetch-pack.c, should we move it to? I ask because I moved fetch-pack from builtin out because of linking issues and I don't want the same happen to sequencer.c.

-- 
Duy
Previous: Felipe ContrerasNext: Felipe Contreras
Message 4 of 82 in “Move sequencer”
  1. 0/2 Move sequencerFelipe Contreras, Jun 7, 2013
  2. 1/2 log-tree: remove dependency from sequencerFelipe Contreras, Jun 7, 2013
  3. 2/2 Move sequencer to builtinFelipe Contreras, Jun 7, 2013
  4. Duy NguyenJun 8, 2013
  5. Felipe ContrerasJun 8, 2013
  6. Duy NguyenJun 8, 2013
  7. Felipe ContrerasJun 8, 2013
  8. Duy NguyenJun 8, 2013
  9. Ramkumar RamachandraJun 8, 2013
  10. Duy NguyenJun 8, 2013
  11. Felipe ContrerasJun 8, 2013
  12. Ramkumar RamachandraJun 8, 2013
  13. Felipe ContrerasJun 8, 2013
  14. Duy NguyenJun 8, 2013
  15. Felipe ContrerasJun 8, 2013
  16. Jeff KingJun 9, 2013
  17. Ramkumar RamachandraJun 9, 2013
  18. Jeff KingJun 9, 2013
  19. Ramkumar RamachandraJun 9, 2013
  20. Felipe ContrerasJun 9, 2013
  21. Jeff KingJun 9, 2013
  22. Felipe ContrerasJun 9, 2013
  23. Ramkumar RamachandraJun 9, 2013
  24. Jeff KingJun 9, 2013
  25. Felipe ContrerasJun 9, 2013
  26. Felipe ContrerasJun 9, 2013
  27. Felipe ContrerasJun 9, 2013
  28. Felipe ContrerasJun 8, 2013
  29. Jonathan NiederJun 8, 2013
  30. Felipe ContrerasJun 8, 2013
  31. Jonathan NiederJun 8, 2013
  32. Felipe ContrerasJun 8, 2013
  33. Felipe ContrerasJun 8, 2013
  34. Jonathan NiederJun 9, 2013
  35. Felipe ContrerasJun 9, 2013
  36. Jonathan NiederJun 9, 2013
  37. Felipe ContrerasJun 9, 2013
  38. Jeff KingJun 9, 2013
  39. Felipe ContrerasJun 9, 2013
  40. Jeff KingJun 9, 2013
  41. Felipe ContrerasJun 9, 2013
  42. Jeff KingJun 9, 2013
  43. Felipe ContrerasJun 9, 2013
  44. Johan HerlandJun 9, 2013
  45. Felipe ContrerasJun 9, 2013
  46. Michael HaggertyJun 9, 2013
  47. Stefano LattariniJun 9, 2013
  48. Felipe ContrerasJun 10, 2013
  49. Bad attitudes and problems in the Git community (was: Re: [PATCH 2/2] Move sequencer to builtin)Stefano Lattarini, Jun 10, 2013
  50. Felipe ContrerasJun 10, 2013
  51. Martin von ZweigbergkJun 10, 2013
  52. Martin LanghoffJun 10, 2013
  53. Martin von ZweigbergkJun 10, 2013
  54. Felipe ContrerasJun 10, 2013
  55. Felipe ContrerasJun 10, 2013
  56. Andres FreundJun 11, 2013
  57. Felipe ContrerasJun 11, 2013
  58. Thiago FarinaJun 20, 2013
  59. Thomas RastJun 9, 2013
  60. Felipe ContrerasJun 9, 2013
  61. Ramkumar RamachandraJun 9, 2013
  62. Felipe ContrerasJun 9, 2013
  63. Jeff KingJun 9, 2013
  64. Ramkumar RamachandraJun 9, 2013
  65. Jeff KingJun 9, 2013
  66. Jonathan NiederJun 9, 2013
  67. Felipe ContrerasJun 9, 2013
  68. Ramkumar RamachandraJun 9, 2013
  69. Junio C HamanoJun 9, 2013
  70. Felipe ContrerasJun 10, 2013
  71. Junio C HamanoJun 10, 2013
  72. Felipe ContrerasJun 10, 2013
  73. Felipe ContrerasJun 10, 2013
  74. Matthieu MoyJun 10, 2013
  75. Ramkumar RamachandraJun 10, 2013
  76. Felipe ContrerasJun 10, 2013
  77. Felipe ContrerasJun 9, 2013
  78. Thomas RastJun 9, 2013
  79. Ramkumar RamachandraJun 9, 2013
  80. Felipe ContrerasJun 9, 2013
  81. Ramkumar RamachandraJun 8, 2013
  82. Felipe ContrerasJun 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.