From: Duy Nguyen Date: Sat, 08 Jun 2013 02:35:37 GMT Subject: Re: [PATCH 2/2] Move sequencer to builtin Message-ID: In-Reply-To: <1370643409-3431-3-git-send-email-felipe.contreras@gmail.com> On Sat, Jun 8, 2013 at 5:16 AM, Felipe Contreras wrote: > This code is only useful for cherry-pick and revert built-ins, nothing > else, so let's make it a builtin object, but make sure 'git-sequencer' > is not generated. As you can see, the convention is builtin/foo.c corresponds to git-foo (and maybe more). Why make an exception for sequencer? What do we gain from this? A lot of code in libgit.a is only used by builtin commands, e.g. fetch-pack.c, should we move it to? I ask because I moved fetch-pack from builtin out because of linking issues and I don't want the same happen to sequencer.c. -- Duy