Re: [PATCH 0/2] Move sequencer

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 8, 2013, 10:26 UTC
Message-ID: <CAMP44s2VpqTDW0GzNMmEmxt-VVwnLEyTjHLV9MQhqd2yqpYFDA@mail.gmail.com>
In-Reply-To: <CALkWK0nbC3jfapvJKuh=m3s1n+GWfTYbhb5DWEjNrFDimQF-KA@mail.gmail.com>

On Fri, Jun 7, 2013 at 10:35 PM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 7 quoted lines

> Felipe Contreras wrote:
>>  sequencer.c => builtin/sequencer.c | 160 +-----------------------------------
>>  sequencer.h => builtin/sequencer.h |   4 -
>
> Why exactly?  The plan was to unify continuation semantics, and get
> all the continuation-commands to use the sequencer.  That clearly
> hasn't materialized, but I don't know what this move buys us.

So? The sequencer is only used by builtin commands, and other continuation commands are also builtins.

The sequencer needs to access methods from builtins/*.o, so unless you propose that libgit.a includes all the objects in builtins/*.o, this is the way to go.

-- 
Felipe Contreras