From: Alex Riesen <raa.lkml@gmail.com>
Date: Sat, 09 Jun 2007 21:37:26 GMT
Subject: Re: [PATCH 10/21] Free mktag's buffer before dying
Message-ID: <81b0412b0706091437j50070e9aw7c258f136f4d5cde@mail.gmail.com>
In-Reply-To: <200706090216.41856.johan@herland.net>

On 6/9/07, Johan Herland <johan@herland.net> wrote:
> +       if (parse_and_verify_tag_buffer(0, buffer, size, 1)) {
> +               free(buffer);
> +               die("invalid tag data file");

This, and the similar one below are useless. You're destroying the
process, what do you free that buffer for? Either handle the error
case or do not needlessly complicate your change, which really
also absolutely unneeded.