Re: [PATCH] daemon: return "access denied" if a service is not allowed
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 14, 2011, 20:48 UTC
- Message-ID
- <7vpqhzxpsc.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20111014203438.GA15643@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
>> It would have been a better split to have the 1/2 patch to support both
>> informative and uninformative errors, with the default to say "access
>> denied", and 2/2 to flip the default to be more open.
>
> Isn't that what I did? It was what I meant to do, anyway...
>
> Or did you mean the options would have been better worded as:
>
> --errors={terse,informative}
>
> or something similar?Nothing that elaborate.
Supporting --no-* variant even when the default is already no will allow people to prepare their daemon invocation command line beforehand to ensure that they won't be affected to a more lenient default that may or may not come in the future. That's all.