Re: [PATCH 1/5] run-command: optionally kill children on exit
- From
Jeff King <peff@peff.net>
- Date
- Jan 7, 2012, 14:41 UTC
- Message-ID
- <20120107144157.GA2461@sigill.intra.peff.net>
- In-Reply-To
- <1325936567-3136-2-git-send-email-drizzd@aon.at>
On Sat, Jan 07, 2012 at 12:42:43PM +0100, Clemens Buchacher wrote:
Show 5 quoted lines
> Signed-off-by: Clemens Buchacher <drizzd@aon.at> > --- > > Not sure if I can sign off without your sign-off. Should I have > replaced this with Acked-by?
Sorry, I usually sign-off when I sent to the list. But:
Signed-off-by: Jeff King <peff@peff.net>
for this and the other patch in this series.
As for whether you can sign-off, I think it is OK in this case. You are basically signing off on the "Certificate of Origin" found in SubmittingPatches. I think you are covered under (b), which is that to the best of your knowledge it is based on open source work (i.e., even though I didn't sign off explicitly, it is pretty obvious that this is meant to be open source). But it's nicer to be explicit.
-Peff