Re: [PATCH 1/2] daemon: add tests
- From
Jeff King <peff@peff.net>
- Date
- Jan 3, 2012, 19:18 UTC
- Message-ID
- <20120103191855.GD20926@sigill.intra.peff.net>
- In-Reply-To
- <20120102194711.GA25296@ecki.lan>
On Mon, Jan 02, 2012 at 08:47:11PM +0100, Clemens Buchacher wrote:
Show 11 quoted lines
> On Mon, Jan 02, 2012 at 03:25:08AM -0600, Jonathan Nieder wrote: > > > > > [Subject: daemon: add tests] > > > > Can't believe I missed this. That seems like a worthy cause --- > > can someone remind me why this is dropped, or if there are any > > tweaks I can help with to get it picked up again? > > We were discussing some open issues with patch 2/2, which was based > on the tests. I later abandoned the idea for that patch. But the > tests should be ok by themselves.
Yes, I'd like to see them included, even without the second patch. We currently have zero tests for git-daemon, so even just verifying that it starts and can let people fetch is an improvement.
-Peff