Re: [PATCH] daemon: return "access denied" if a service is not allowed
- From
Jeff King <peff@peff.net>
- Date
- Oct 14, 2011, 21:05 UTC
- Message-ID
- <20111014210506.GA16226@sigill.intra.peff.net>
- In-Reply-To
- <7vpqhzxpsc.fsf@alter.siamese.dyndns.org>
On Fri, Oct 14, 2011 at 01:48:51PM -0700, Junio C Hamano wrote:
Show 20 quoted lines
> Jeff King <peff@peff.net> writes:
>
> >> It would have been a better split to have the 1/2 patch to support both
> >> informative and uninformative errors, with the default to say "access
> >> denied", and 2/2 to flip the default to be more open.
> >
> > Isn't that what I did? It was what I meant to do, anyway...
> >
> > Or did you mean the options would have been better worded as:
> >
> > --errors={terse,informative}
> >
> > or something similar?
>
> Nothing that elaborate.
>
> Supporting --no-* variant even when the default is already no will allow
> people to prepare their daemon invocation command line beforehand to ensure
> that they won't be affected to a more lenient default that may or may not
> come in the future. That's all.Oh. Then look again at 1/2. It supports both forms; I just didn't bother advertising the --no form in the manpage, since it was the default.
-Peff