Re: [PATCHv3] daemon: give friendlier error messages to clients

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 15, 2011, 08:26 UTC
Message-ID: <20111015082647.GA7302@elie.hsd1.il.comcast.net>
In-Reply-To: <m3r52e7js7.fsf@localhost.localdomain>

Jakub Narebski wrote:

> Sitaram Chamarty <sitaramc@gmail.com> writes:

Show 10 quoted lines

>> "Access denied or no such repo" is much better.  (The "not exported"
>> nuance is not relevant in this context; you can safely ignore it.)
>
> To join this bike-shedding:
>
>   "Access denied or repository not available"
>
> or just
>
>   "Repository not available"

If such details about the message matter, then I have to say that Sitaram's "access denied or no such repository" is as close to perfect as I can imagine. The admin who is eventually forwarded this message will be reminded to check two things:

 - that access is not denied, neither globally, using a whitelist,
   using filesystem permissions, nor by leaving out
   git-daemon-export-ok, and

 - that such a repo exists at all, and there was not a typo in the
   address.